libsas: use ata_is_ncq() and ata_has_dma() accessors
authorHannes Reinecke <hare@suse.de>
Thu, 14 Jul 2016 00:05:44 +0000 (09:05 +0900)
committerTejun Heo <tj@kernel.org>
Thu, 14 Jul 2016 14:45:02 +0000 (10:45 -0400)
Use accessors instead of the raw protocol value.

Signed-off-by: Hannes Reinecke <hare@suse.com>
[hch: trivial cleanup of the ata_task assignments]
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Tejun Heo <tj@kernel.org>
drivers/scsi/libsas/sas_ata.c

index 935c430..497bc15 100644 (file)
@@ -233,15 +233,8 @@ static unsigned int sas_ata_qc_issue(struct ata_queued_cmd *qc)
        task->task_state_flags = SAS_TASK_STATE_PENDING;
        qc->lldd_task = task;
 
-       switch (qc->tf.protocol) {
-       case ATA_PROT_NCQ:
-               task->ata_task.use_ncq = 1;
-               /* fall through */
-       case ATAPI_PROT_DMA:
-       case ATA_PROT_DMA:
-               task->ata_task.dma_xfer = 1;
-               break;
-       }
+       task->ata_task.use_ncq = ata_is_ncq(qc->tf.protocol);
+       task->ata_task.dma_xfer = ata_is_dma(qc->tf.protocol);
 
        if (qc->scsicmd)
                ASSIGN_SAS_TASK(qc->scsicmd, task);