HID: rmi: fix wrong struct field name
authorJiri Kosina <jkosina@suse.cz>
Tue, 13 May 2014 19:17:29 +0000 (21:17 +0200)
committerJiri Kosina <jkosina@suse.cz>
Tue, 13 May 2014 19:17:39 +0000 (21:17 +0200)
x_size_mm should be y_size_mm, otherwise neither the duplicated
condition nor the assignment make any sense whatsoever.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-rmi.c

index 05e4928..7ebdc96 100644 (file)
@@ -787,9 +787,9 @@ static void rmi_input_configured(struct hid_device *hdev, struct hid_input *hi)
        input_set_abs_params(input, ABS_MT_POSITION_X, 1, data->max_x, 0, 0);
        input_set_abs_params(input, ABS_MT_POSITION_Y, 1, data->max_y, 0, 0);
 
-       if (data->x_size_mm && data->x_size_mm) {
+       if (data->x_size_mm && data->y_size_mm) {
                res_x = (data->max_x - 1) / data->x_size_mm;
-               res_y = (data->max_y - 1) / data->x_size_mm;
+               res_y = (data->max_y - 1) / data->y_size_mm;
 
                input_abs_set_res(input, ABS_MT_POSITION_X, res_x);
                input_abs_set_res(input, ABS_MT_POSITION_Y, res_y);