sched/cpuacct: Check for NULL when using task_pt_regs()
authorAnton Blanchard <anton@samba.org>
Wed, 6 Apr 2016 11:59:50 +0000 (21:59 +1000)
committerIngo Molnar <mingo@kernel.org>
Wed, 13 Apr 2016 11:22:37 +0000 (13:22 +0200)
task_pt_regs() can return NULL for kernel threads, so add a check.
This fixes an oops at boot on ppc64.

Reported-and-Tested-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Tested-by: Zhao Lei <zhaolei@cn.fujitsu.com>
Signed-off-by: Anton Blanchard <anton@samba.org>
Acked-by: Zhao Lei <zhaolei@cn.fujitsu.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: efault@gmx.de
Cc: htejun@gmail.com
Cc: linuxppc-dev@lists.ozlabs.org
Cc: tj@kernel.org
Cc: yangds.fnst@cn.fujitsu.com
Link: http://lkml.kernel.org/r/20160406215950.04bc3f0b@kryten
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/sched/cpuacct.c

index df947e0..41f85c4 100644 (file)
@@ -316,12 +316,11 @@ static struct cftype files[] = {
 void cpuacct_charge(struct task_struct *tsk, u64 cputime)
 {
        struct cpuacct *ca;
-       int index;
+       int index = CPUACCT_USAGE_SYSTEM;
+       struct pt_regs *regs = task_pt_regs(tsk);
 
-       if (user_mode(task_pt_regs(tsk)))
+       if (regs && user_mode(regs))
                index = CPUACCT_USAGE_USER;
-       else
-               index = CPUACCT_USAGE_SYSTEM;
 
        rcu_read_lock();