i40e: remove a stray unlock
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 3 Aug 2016 19:01:07 +0000 (22:01 +0300)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Thu, 18 Aug 2016 18:43:14 +0000 (11:43 -0700)
We shifted the locking around a bit but forgot to delete this unlock so
now it can unlock twice.

Fixes: cd3be169a5ff ('i40e: Move the mutex lock in i40e_client_unregister')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/i40e/i40e_client.c

index 90b435c..677dae5 100644 (file)
@@ -992,7 +992,6 @@ int i40e_unregister_client(struct i40e_client *client)
        if (!i40e_client_is_registered(client)) {
                pr_info("i40e: Client %s has not been registered\n",
                        client->name);
        if (!i40e_client_is_registered(client)) {
                pr_info("i40e: Client %s has not been registered\n",
                        client->name);
-               mutex_unlock(&i40e_client_mutex);
                ret = -ENODEV;
                goto out;
        }
                ret = -ENODEV;
                goto out;
        }