staging: bcm: nvm.c: Cleaning up check unsigned is less than zero
authorRickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Wed, 25 Jun 2014 14:38:01 +0000 (16:38 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 27 Jun 2014 01:08:46 +0000 (21:08 -0400)
Remove checking if a unsigned int is less than zero

This was found using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/bcm/nvm.c

index d56ca3b..99b82d8 100644 (file)
@@ -3321,7 +3321,7 @@ int BcmSetActiveSection(struct bcm_mini_adapter *Adapter, enum bcm_flash2x_secti
 
                        SectImagePriority = ReadISOPriority(Adapter, HighestPriISO) + 1;
 
-                       if ((SectImagePriority <= 0) && IsSectionWritable(Adapter, HighestPriISO)) {
+                       if ((SectImagePriority == 0) && IsSectionWritable(Adapter, HighestPriISO)) {
                                /* This is a SPECIAL Case which will only happen if the current highest priority ISO has priority value = 0x7FFFFFFF.
                                 * We will write 1 to the current Highest priority ISO And then shall increase the priority of the requested ISO
                                 * by user
@@ -3381,7 +3381,7 @@ int BcmSetActiveSection(struct bcm_mini_adapter *Adapter, enum bcm_flash2x_secti
                        }
 
                        SectImagePriority = ReadDSDPriority(Adapter, HighestPriDSD) + 1;
-                       if (SectImagePriority <= 0) {
+                       if (SectImagePriority == 0) {
                                /* This is a SPECIAL Case which will only happen if the current highest priority DSD has priority value = 0x7FFFFFFF.
                                 * We will write 1 to the current Highest priority DSD And then shall increase the priority of the requested DSD
                                 * by user