blkpm: avoid sleep when holding queue lock
authorAaron Lu <aaron.lu@intel.com>
Fri, 17 May 2013 07:47:20 +0000 (15:47 +0800)
committerJens Axboe <axboe@kernel.dk>
Fri, 17 May 2013 08:00:43 +0000 (10:00 +0200)
In blk_post_runtime_resume, an autosuspend request will be initiated for
the device. Since we are holding the queue lock, we can't sleep and thus
we should use the async version to initiate an autosuspend, i.e.
pm_request_suspend instead of pm_runtime_suspend, which might sleep.

Signed-off-by: Aaron Lu <aaron.lu@intel.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-core.c

index 33c33bc..d5745b5 100644 (file)
@@ -3164,7 +3164,7 @@ void blk_post_runtime_resume(struct request_queue *q, int err)
                q->rpm_status = RPM_ACTIVE;
                __blk_run_queue(q);
                pm_runtime_mark_last_busy(q->dev);
-               pm_runtime_autosuspend(q->dev);
+               pm_request_autosuspend(q->dev);
        } else {
                q->rpm_status = RPM_SUSPENDED;
        }