EDAC, sb_edac: Remove NULL pointer check on array pci_tad
authorColin Ian King <colin.king@canonical.com>
Thu, 8 Sep 2016 08:38:01 +0000 (09:38 +0100)
committerBorislav Petkov <bp@suse.de>
Mon, 12 Sep 2016 18:15:43 +0000 (20:15 +0200)
pvt->pci_tad is a NUM_CHANNELS array of struct pci_dev pointers and
hence cannot be NULL, so the NULL pointer check on pci_tad is redundant.
Remove it.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Tony Luck <tony.luck@intel.com>
Cc: linux-edac <linux-edac@vger.kernel.org>
Link: http://lkml.kernel.org/r/20160908083801.14766-1-colin.king@canonical.com
Signed-off-by: Borislav Petkov <bp@suse.de>
drivers/edac/sb_edac.c

index 4fb2eb7..04aafdd 100644 (file)
@@ -2474,7 +2474,7 @@ static int sbridge_mci_bind_devs(struct mem_ctl_info *mci,
 
        /* Check if everything were registered */
        if (!pvt->pci_sad0 || !pvt->pci_sad1 || !pvt->pci_ha0 ||
-           !pvt-> pci_tad || !pvt->pci_ras  || !pvt->pci_ta)
+           !pvt->pci_ras || !pvt->pci_ta)
                goto enodev;
 
        if (saw_chan_mask != 0x0f)
@@ -2563,8 +2563,7 @@ static int ibridge_mci_bind_devs(struct mem_ctl_info *mci,
 
        /* Check if everything were registered */
        if (!pvt->pci_sad0 || !pvt->pci_ha0 || !pvt->pci_br0 ||
-           !pvt->pci_br1 || !pvt->pci_tad || !pvt->pci_ras  ||
-           !pvt->pci_ta)
+           !pvt->pci_br1 || !pvt->pci_ras || !pvt->pci_ta)
                goto enodev;
 
        if (saw_chan_mask != 0x0f && /* -EN */