mailbox: PCC: Fix return value of pcc_mbox_request_channel()
authorHoan Tran <hotran@apm.com>
Fri, 14 Oct 2016 23:20:21 +0000 (16:20 -0700)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 17 Oct 2016 12:26:49 +0000 (14:26 +0200)
When CONFIG_PCC is disabled, pcc_mbox_request_channel() needs to
return ERR_PTR(-ENODEV), not a NULL pointer, as the callers of
this function use IS_ERR() to check for error code.

Signed-off-by: Duc Dang <dhdang@apm.com>
Signed-off-by: Hoan Tran <hotran@apm.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
include/acpi/pcc.h

index 17a940a..8caa79c 100644 (file)
@@ -21,7 +21,7 @@ extern void pcc_mbox_free_channel(struct mbox_chan *chan);
 static inline struct mbox_chan *pcc_mbox_request_channel(struct mbox_client *cl,
                                                         int subspace_id)
 {
-       return NULL;
+       return ERR_PTR(-ENODEV);
 }
 static inline void pcc_mbox_free_channel(struct mbox_chan *chan) { }
 #endif