mmc: core: Keep host claimed in mmc_rescan() while calling host ops
authorUlf Hansson <ulf.hansson@linaro.org>
Thu, 5 Nov 2015 15:08:08 +0000 (16:08 +0100)
committerUlf Hansson <ulf.hansson@linaro.org>
Tue, 22 Dec 2015 10:32:02 +0000 (11:32 +0100)
As mmc_claim_host() invokes pm_runtime_get_sync() for the mmc host device,
it's important that the host is kept claimed for *all* accesses to it via
the host_ops callbacks.

In mmc_rescan(), the ->card_event() and the ->get_cd() callback are being
invoked without claiming the host, let's fix this.

Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/core/core.c

index c1027a4..394963d 100644 (file)
@@ -2576,7 +2576,9 @@ void mmc_rescan(struct work_struct *work)
        host->rescan_entered = 1;
 
        if (host->trigger_card_event && host->ops->card_event) {
+               mmc_claim_host(host);
                host->ops->card_event(host);
+               mmc_release_host(host);
                host->trigger_card_event = false;
        }
 
@@ -2611,15 +2613,14 @@ void mmc_rescan(struct work_struct *work)
         */
        mmc_bus_put(host);
 
+       mmc_claim_host(host);
        if (!(host->caps & MMC_CAP_NONREMOVABLE) && host->ops->get_cd &&
                        host->ops->get_cd(host) == 0) {
-               mmc_claim_host(host);
                mmc_power_off(host);
                mmc_release_host(host);
                goto out;
        }
 
-       mmc_claim_host(host);
        for (i = 0; i < ARRAY_SIZE(freqs); i++) {
                if (!mmc_rescan_try_freq(host, max(freqs[i], host->f_min)))
                        break;