HSI: nokia-modem: fix error handling of irq_of_parse_and_map
authorDmitry Torokhov <dtor@chromium.org>
Fri, 14 Nov 2014 22:06:37 +0000 (14:06 -0800)
committerSebastian Reichel <sre@kernel.org>
Fri, 14 Nov 2014 22:39:40 +0000 (23:39 +0100)
Return value of irq_of_parse_and_map() is unsigned int, with 0
indicating failure, so testing for negative result never works.

Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
Signed-off-by: Sebastian Reichel <sre@kernel.org>
drivers/hsi/clients/nokia-modem.c

index 67b8e8f..f0c2145 100644 (file)
@@ -164,9 +164,9 @@ static int nokia_modem_probe(struct device *dev)
        dev_set_drvdata(dev, modem);
 
        irq = irq_of_parse_and_map(np, 0);
-       if (irq < 0) {
+       if (!irq) {
                dev_err(dev, "Invalid rst_ind interrupt (%d)\n", irq);
-               return irq;
+               return -EINVAL;
        }
        modem->nokia_modem_rst_ind_irq = irq;
        pflags = irq_get_trigger_type(irq);