mlx4: remove redundant adding of steering type to gid
authorEugenia Emantayev <eugenia@mellanox.co.il>
Tue, 14 Feb 2012 06:38:12 +0000 (06:38 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 14 Feb 2012 19:11:58 +0000 (14:11 -0500)
mlx4_uc_steer_add/release() should not add MLX4_UC_STEER flag to gid.
It is added in mlx4_unicast_attach/detach().

Signed-off-by: Eugenia Emantayev <eugenia@mellanox.co.il>
Reviewed-by: Yevgeny Petrilin <yevgenyp@mellanox.co.il>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlx4/port.c

index f44ae55..575839d 100644 (file)
@@ -87,7 +87,6 @@ static int mlx4_uc_steer_add(struct mlx4_dev *dev, u8 port, u64 mac, int *qpn)
        mac = cpu_to_be64(mac << 16);
        memcpy(&gid[10], &mac, ETH_ALEN);
        gid[5] = port;
-       gid[7] = MLX4_UC_STEER << 1;
 
        err = mlx4_unicast_attach(dev, &qp, gid, 0, MLX4_PROT_ETH);
        if (err)
@@ -107,7 +106,6 @@ static void mlx4_uc_steer_release(struct mlx4_dev *dev, u8 port,
        mac = cpu_to_be64(mac << 16);
        memcpy(&gid[10], &mac, ETH_ALEN);
        gid[5] = port;
-       gid[7] = MLX4_UC_STEER << 1;
 
        mlx4_unicast_detach(dev, &qp, gid, MLX4_PROT_ETH);
 }