ntb_netdev: Fix skb free issue in open
authorJon Mason <jon.mason@intel.com>
Fri, 22 Nov 2013 23:50:57 +0000 (16:50 -0700)
committerJon Mason <jon.mason@intel.com>
Mon, 7 Apr 2014 17:58:14 +0000 (10:58 -0700)
In ntb_netdev_open, when ntb_transport_rx_enqueue fails the skb that was
attempting to be enqueued is not freed.  Free this skb on the
ntb_transport_rx_enqueue error.

Signed-off-by: Jon Mason <jon.mason@intel.com>
drivers/net/ntb_netdev.c

index 8298880..8e6752f 100644 (file)
@@ -182,8 +182,10 @@ static int ntb_netdev_open(struct net_device *ndev)
 
                rc = ntb_transport_rx_enqueue(dev->qp, skb, skb->data,
                                              ndev->mtu + ETH_HLEN);
-               if (rc == -EINVAL)
+               if (rc == -EINVAL) {
+                       dev_kfree_skb(skb);
                        goto err;
+               }
        }
 
        netif_carrier_off(ndev);