mdio_bus: don't return NULL from mdiobus_scan()
authorSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Tue, 3 May 2016 20:14:41 +0000 (23:14 +0300)
committerDavid S. Miller <davem@davemloft.net>
Wed, 4 May 2016 20:14:19 +0000 (16:14 -0400)
I've finally noticed that mdiobus_scan() also returns either NULL or error
value on failure.  Return ERR_PTR(-ENODEV) instead of NULL since this is
the  error value  already filtered out by the callers that want to ignore
the  MDIO address scan failure...

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/mdio_bus.c

index 388f992..09deef4 100644 (file)
@@ -431,7 +431,7 @@ struct phy_device *mdiobus_scan(struct mii_bus *bus, int addr)
        err = phy_device_register(phydev);
        if (err) {
                phy_device_free(phydev);
-               return NULL;
+               return ERR_PTR(-ENODEV);
        }
 
        return phydev;