tracing/uprobes: Kill the dead TRACE_EVENT_FL_USE_CALL_FILTER logic
authorOleg Nesterov <oleg@redhat.com>
Tue, 15 Jul 2014 18:48:24 +0000 (20:48 +0200)
committerSteven Rostedt <rostedt@goodmis.org>
Wed, 16 Jul 2014 18:25:19 +0000 (14:25 -0400)
alloc_trace_uprobe() sets TRACE_EVENT_FL_USE_CALL_FILTER for unknown
reason and this is simply wrong. Fortunately this has no effect because
register_uprobe_event() clears call->flags after that.

Kill both. This trace_uprobe was kzalloc'ed and we rely on this fact
anyway.

Link: http://lkml.kernel.org/p/20140715184824.GA20505@redhat.com
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
kernel/trace/trace_uprobe.c

index 3c9b97e..33ff6a2 100644 (file)
@@ -265,7 +265,6 @@ alloc_trace_uprobe(const char *group, const char *event, int nargs, bool is_ret)
        if (is_ret)
                tu->consumer.ret_handler = uretprobe_dispatcher;
        init_trace_uprobe_filter(&tu->filter);
-       tu->tp.call.flags |= TRACE_EVENT_FL_USE_CALL_FILTER;
        return tu;
 
 error:
@@ -1292,7 +1291,7 @@ static int register_uprobe_event(struct trace_uprobe *tu)
                kfree(call->print_fmt);
                return -ENODEV;
        }
-       call->flags = 0;
+
        call->class->reg = trace_uprobe_register;
        call->data = tu;
        ret = trace_add_event_call(call);