fs/fat/inode.c: clean up string initializations (char[] instead of char *)
authorManuel Schölling <manuel.schoelling@gmx.de>
Fri, 6 Jun 2014 21:36:38 +0000 (14:36 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 6 Jun 2014 23:08:11 +0000 (16:08 -0700)
Initializations like 'char *foo = "bar"' will create two variables: a
static string and a pointer (foo) to that static string.  Instead 'char
foo[] = "bar"' will declare a single variable and will end up in shorter
assembly (according to Jeff Garzik on the KernelJanitor's TODO list).

Signed-off-by: Manuel Schölling <manuel.schoelling@gmx.de>
Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/fat/inode.c

index babff0f..9c83594 100644 (file)
@@ -421,7 +421,7 @@ struct inode *fat_iget(struct super_block *sb, loff_t i_pos)
 
 static int is_exec(unsigned char *extension)
 {
-       unsigned char *exe_extensions = "EXECOMBAT", *walk;
+       unsigned char exe_extensions[] = "EXECOMBAT", *walk;
 
        for (walk = exe_extensions; *walk; walk += 3)
                if (!strncmp(extension, walk, 3))