ath6kl: use list_move_tail instead of list_del/list_add_tail
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>
Wed, 5 Sep 2012 07:07:29 +0000 (15:07 +0800)
committerKalle Valo <kvalo@qca.qualcomm.com>
Wed, 24 Oct 2012 08:49:50 +0000 (11:49 +0300)
Using list_move_tail() instead of list_del() + list_add_tail().

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
drivers/net/wireless/ath/ath6kl/htc_pipe.c

index f9626c7..ba6bd49 100644 (file)
@@ -374,9 +374,8 @@ static enum htc_send_queue_result htc_try_send(struct htc_target *target,
                                packet = list_first_entry(txq,
                                                          struct htc_packet,
                                                          list);
-                               list_del(&packet->list);
-                               /* insert into local queue */
-                               list_add_tail(&packet->list, &send_queue);
+                               /* move to local queue */
+                               list_move_tail(&packet->list, &send_queue);
                        }
 
                        /*
@@ -399,11 +398,10 @@ static enum htc_send_queue_result htc_try_send(struct htc_target *target,
                                         * for cleanup */
                                } else {
                                        /* callback wants to keep this packet,
-                                        * remove from caller's queue */
-                                       list_del(&packet->list);
-                                       /* put it in the send queue */
-                                       list_add_tail(&packet->list,
-                                                     &send_queue);
+                                        * move from caller's queue to the send
+                                        * queue */
+                                       list_move_tail(&packet->list,
+                                                      &send_queue);
                                }
 
                        }