atmel: Remove typedef atmel_priv_ioctl
authorHimangi Saraogi <himangi774@gmail.com>
Sat, 9 Aug 2014 16:22:20 +0000 (21:52 +0530)
committerDavid S. Miller <davem@davemloft.net>
Mon, 11 Aug 2014 19:19:53 +0000 (12:19 -0700)
The Linux kernel coding style guidelines suggest not using typedefs
for structure types. This patch gets rid of the typedef for
atmel_priv_ioctl.

The following Coccinelle semantic patch detects the case:

@tn@
identifier i;
type td;
@@

-typedef
 struct i { ... }
-td
 ;

@@
type tn.td;
identifier tn.i;
@@

-td
+ struct i

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/wireless/atmel.c

index 1fe41af..9183f1c 100644 (file)
@@ -2598,11 +2598,11 @@ static const iw_handler atmel_private_handler[] =
        NULL,                           /* SIOCIWFIRSTPRIV */
 };
 
-typedef struct atmel_priv_ioctl {
+struct atmel_priv_ioctl {
        char id[32];
        unsigned char __user *data;
        unsigned short len;
-} atmel_priv_ioctl;
+};
 
 #define ATMELFWL       SIOCIWFIRSTPRIV
 #define ATMELIDIFC     ATMELFWL + 1
@@ -2615,7 +2615,7 @@ static const struct iw_priv_args atmel_private_args[] = {
                .cmd = ATMELFWL,
                .set_args = IW_PRIV_TYPE_BYTE
                                | IW_PRIV_SIZE_FIXED
-                               | sizeof (atmel_priv_ioctl),
+                               | sizeof(struct atmel_priv_ioctl),
                .get_args = IW_PRIV_TYPE_NONE,
                .name = "atmelfwl"
        }, {
@@ -2645,7 +2645,7 @@ static int atmel_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)
 {
        int i, rc = 0;
        struct atmel_private *priv = netdev_priv(dev);
-       atmel_priv_ioctl com;
+       struct atmel_priv_ioctl com;
        struct iwreq *wrq = (struct iwreq *) rq;
        unsigned char *new_firmware;
        char domain[REGDOMAINSZ + 1];