dm cache: always split discards on cache block boundaries
authorHeinz Mauelshagen <heinzm@redhat.com>
Fri, 23 May 2014 18:10:01 +0000 (14:10 -0400)
committerMike Snitzer <snitzer@redhat.com>
Tue, 27 May 2014 14:33:05 +0000 (10:33 -0400)
The DM cache target cannot cope with discards that span multiple cache
blocks, so each discard bio that spans more than one cache block must
get split by the DM core.

Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Acked-by: Joe Thornber <ejt@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Cc: stable@vger.kernel.org # v3.9+
drivers/md/dm-cache-target.c

index 9380be7..5f054c4 100644 (file)
@@ -2178,6 +2178,8 @@ static int cache_create(struct cache_args *ca, struct cache **result)
        ti->num_discard_bios = 1;
        ti->discards_supported = true;
        ti->discard_zeroes_data_unsupported = true;
+       /* Discard bios must be split on a block boundary */
+       ti->split_discard_bios = true;
 
        cache->features = ca->features;
        ti->per_bio_data_size = get_per_bio_data_size(cache);