Remove duplicate call to subfacet_create().
authorJarno Rajahalme <jrajahalme@nicira.com>
Thu, 22 Aug 2013 22:51:39 +0000 (15:51 -0700)
committerBen Pfaff <blp@nicira.com>
Fri, 23 Aug 2013 17:47:06 +0000 (10:47 -0700)
There were two calls to subfacet_create(), which is redundant.  The first
one seemed the one to remove, as there is a subsequent test on the facet's
subfacet list being empty, which is never true after a call to
subfacet_create().  The correctness of this needs to be checked, however.

Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com>
Signed-off-by: Ben Pfaff <blp@nicira.com>
ofproto/ofproto-dpif.c

index 6b2bd22..c7e32ef 100644 (file)
@@ -3340,7 +3340,6 @@ handle_flow_miss_with_facet(struct flow_miss *miss, struct facet *facet,
     facet->byte_count += miss->stats.n_bytes;
     facet->prev_byte_count += miss->stats.n_bytes;
 
-    subfacet = subfacet_create(facet, miss);
     want_path = facet->xout.slow ? SF_SLOW_PATH : SF_FAST_PATH;
 
     /* Don't install the flow if it's the result of the "userspace"