datapath-windows: Fix assertion in Netlink.c
authorAnkur Sharma <ankursharma@vmware.com>
Sat, 11 Oct 2014 22:07:41 +0000 (15:07 -0700)
committerBen Pfaff <blp@nicira.com>
Mon, 13 Oct 2014 21:23:08 +0000 (14:23 -0700)
NlBufAt should be called with valid boundary limits (within head and tail).
Incorrect argument to NlBufAt was leading to assert hit, fixed the same.

Signed-off-by: Ankur Sharma <ankursharma@vmware.com>
Acked-by: Nithin Raju <nithin@vmware.com>
Tested-by: Nithin Raju <nithin@vmware.com>
Signed-off-by: Ben Pfaff <blp@nicira.com>
datapath-windows/ovsext/Netlink/Netlink.c

index 7ec651f..ae10a87 100644 (file)
@@ -51,7 +51,7 @@ NlFillOvsMsg(PNL_BUFFER nlBuf, UINT16 nlmsgType,
 
     /* To keep compiler happy for release build. */
     UNREFERENCED_PARAMETER(offset);
-    ASSERT(NlBufAt(nlBuf, offset, sizeof(struct _OVS_MESSAGE)) != 0);
+    ASSERT(NlBufAt(nlBuf, offset, 0) != 0);
 
     msgOut.nlMsg.nlmsgType = nlmsgType;
     msgOut.nlMsg.nlmsgFlags = nlmsgFlags;
@@ -88,7 +88,7 @@ NlFillNlHdr(PNL_BUFFER nlBuf, UINT16 nlmsgType,
 
     /* To keep compiler happy for release build. */
     UNREFERENCED_PARAMETER(offset);
-    ASSERT(NlBufAt(nlBuf, offset, sizeof(struct _NL_MSG_HDR)) != 0);
+    ASSERT(NlBufAt(nlBuf, offset, 0) != 0);
 
     msgOut.nlmsgType = nlmsgType;
     msgOut.nlmsgFlags = nlmsgFlags;