dpif-netdev: Reduce code duplication
authorAndy Zhou <azhou@ovn.org>
Tue, 26 Jan 2016 02:51:11 +0000 (18:51 -0800)
committerAndy Zhou <azhou@ovn.org>
Thu, 28 Jan 2016 01:25:45 +0000 (17:25 -0800)
Code clean up to reduce code duplication.

Signed-off-by: Andy Zhou <azhou@ovn.org>
Acked-by: Daniele Di Proietto <diproiettod@vmware.com>
lib/dpif-netdev.c

index 661d2b0..833174a 100644 (file)
@@ -3275,13 +3275,11 @@ dp_netdev_queue_batches(struct dp_packet *pkt,
 {
     struct packet_batch *batch = flow->batch;
 
-    if (OVS_LIKELY(batch)) {
-        packet_batch_update(batch, pkt, mf);
-        return;
+    if (OVS_UNLIKELY(!batch)) {
+        batch = &batches[(*n_batches)++];
+        packet_batch_init(batch, flow);
     }
 
-    batch = &batches[(*n_batches)++];
-    packet_batch_init(batch, flow);
     packet_batch_update(batch, pkt, mf);
 }