f2fs: fix memory leak after kobject init failed in fill_super
authorChao Yu <chao2.yu@samsung.com>
Thu, 7 Nov 2013 02:14:51 +0000 (10:14 +0800)
committerJaegeuk Kim <jaegeuk.kim@samsung.com>
Fri, 8 Nov 2013 05:10:29 +0000 (14:10 +0900)
If we failed to init&add kobject when fill_super, stats info and proc object of
f2fs will not be released.
We should free them before we finish fill_super.

Signed-off-by: Chao Yu <chao2.yu@samsung.com>
Signed-off-by: Jaegeuk Kim <jaegeuk.kim@samsung.com>
fs/f2fs/super.c

index 00e79df..bafff72 100644 (file)
@@ -975,12 +975,12 @@ static int f2fs_fill_super(struct super_block *sb, void *data, int silent)
                /* After POR, we can run background GC thread.*/
                err = start_gc_thread(sbi);
                if (err)
-                       goto fail;
+                       goto free_gc;
        }
 
        err = f2fs_build_stats(sbi);
        if (err)
-               goto fail;
+               goto free_gc;
 
        if (f2fs_proc_root)
                sbi->s_proc = proc_mkdir(sb->s_id, f2fs_proc_root);
@@ -1006,6 +1006,12 @@ static int f2fs_fill_super(struct super_block *sb, void *data, int silent)
 
        return 0;
 fail:
+       if (sbi->s_proc) {
+               remove_proc_entry("segment_info", sbi->s_proc);
+               remove_proc_entry(sb->s_id, f2fs_proc_root);
+       }
+       f2fs_destroy_stats(sbi);
+free_gc:
        stop_gc_thread(sbi);
 free_root_inode:
        dput(sb->s_root);