UBI: Clean up return in ubi_remove_volume()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 13 Apr 2016 06:41:26 +0000 (09:41 +0300)
committerRichard Weinberger <richard@nod.at>
Tue, 24 May 2016 13:24:26 +0000 (15:24 +0200)
My static checker says that "err" can be uninitialized if
"vol->reserved_pebs" is <= 0.  I don't think that can happen but
returning a literal is cleaner anyway.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
drivers/mtd/ubi/vmt.c

index 1ae17bb..10059df 100644 (file)
@@ -405,7 +405,7 @@ int ubi_remove_volume(struct ubi_volume_desc *desc, int no_vtbl)
        if (!no_vtbl)
                self_check_volumes(ubi);
 
        if (!no_vtbl)
                self_check_volumes(ubi);
 
-       return err;
+       return 0;
 
 out_err:
        ubi_err(ubi, "cannot remove volume %d, error %d", vol_id, err);
 
 out_err:
        ubi_err(ubi, "cannot remove volume %d, error %d", vol_id, err);